Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: You are again mixing different unrelated stuff in the same patch, which is confusing when reviewing the patch. Please split this into separate orthogonal topics. Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/c5f24c56_cb0ca592?usp=email : PS1, Line 12: - Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use This should be a separate commit, since it's not related at all to the other ones. File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/14fc29ce_10129c84?usp=email : PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes") Why are you adding ENABLE_TUN? It's never set to "no". File include/osmocom/core/netns.h: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/e98278ba_4c7b1c2f?usp=email : PS1, Line 5: #if (USE_NETNS) if netns is not supported, modify Makefile.am to avoid adding this file to the buildset. File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/82f9dd24_be2f883e?usp=email : PS1, Line 83: if ENABLE_TUN WHy this? AFAICT it can ever be false? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 12:07:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
