Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41812?usp=email )

Change subject: transport/init: use PySimLogger to print messages
......................................................................


Patch Set 2:

(2 comments)

File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/41812/comment/ebd4111c_b3b280ea?usp=email :
PS1, Line 34: TRANSPORT
> I am wondering why are you doing this instead of using `__name__`. […]
I wasn't aware that there is a deeper concept behind the logger name. I have 
now put a patch before this one to align that.


https://gerrit.osmocom.org/c/pysim/+/41812/comment/7681b717_b6df0209?usp=email :
PS1, Line 49: log.info
> Please use lazy format string rendering here and below.
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3
Gerrit-Change-Number: 41812
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 20 Jan 2026 13:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to