Attention is currently required from: Ben I.

fixeria has posted comments on this change by Ben I. ( 
https://gerrit.osmocom.org/c/pysim/+/41913?usp=email )

Change subject: Decode GSM 7-bit packed EF.PNN data
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File pySim/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/41913/comment/73037ea6_6ef60476?usp=email :
PS1, Line 889:     # TODO: 
430a82d432bbbc7eb75de432450a82d432bbbc7eb75de432ffffffff
             :
Why removing these TODOs? They could be included in `_test_de_encode[]` too.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41913?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4558fd011592aeeae2389fe8a1f62f3d7e21d219
Gerrit-Change-Number: 41913
Gerrit-PatchSet: 1
Gerrit-Owner: Ben I <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: Ben I <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jan 2026 20:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to