Attention is currently required from: daniel, fixeria, jolly, laforge, osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email )

Change subject: osmo_io: Reorder iofd_handle_segmented_read()
......................................................................


Patch Set 1:

(1 comment)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/41910/comment/cc5a7a28_fd73aeb5?usp=email
 :
PS1, Line 362: vo
> I'm wondering  why this function is not declared static? I can only see one 
> user and that's in the   […]
Ack. Maybe it was called before in some other place, because I can see it 
defined in osmo_io_internal.h. I'll submit an extra patch making it static.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480
Gerrit-Change-Number: 41910
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to