Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: detect netns support via configure-time capability checks ...................................................................... Patch Set 6: (1 comment) File include/osmocom/core/netdev.h: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/cb764712_f2987e37?usp=email : PS6, Line 6: #include "config.h" > You cannot include config here, since this is a public header used by other > projects, while "config. […] Understood, thanks for pointing this out. You're right: config.h must not be included from a public header. The reason I added it was to fix a compilation error in gprs_ns2_fr.c, where config.h is included after netdev.h, so the required USE_NETNS defines were not visible. I'll rework this accordingly and remove the config.h include from the public header. As discussed, I'll instead keep the API visible and guard the implementation with HAVE_* checks, returning -ENOTSUP where the required features are unavailable. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
