Attention is currently required from: Timur Davydov, laforge, neels. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 16: (5 comments) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/066ee530_5bf11a10?usp=email : PS16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes") This will still probably need fixing in a separate patch like the NETNS stuff you fixed File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/a5d9572f_36a31197?usp=email : PS16, Line 87: if ENABLE_TUN This will probably need some sort of other fix? Why can't you add it when building for emscripten? File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/9565e2dc_c620c5a9?usp=email : PS16, Line 5: #include "../config.h" This and the change below deserve a separate patch, feel free to submit previously in the branch to gerrit. File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/18878f2d_71b02573?usp=email : PS16, Line 198: #if !defined(__EMSCRIPTEN__) This should be fixed in a more generic way. Why can't you build this with emscripten? what's the exact error? we should check for that. File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/1c39ef23_92e03429?usp=email : PS16, Line 937: #if !defined(__EMSCRIPTEN__) what about leaving this in and let it fail during runtime if user tries to use it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 16 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 14:53:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
