Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email )
Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41912/comment/37d0338a_943ade48?usp=email : PS2, Line 1071: 0xffff > cosmetic: use `UINT16_MAX`? I think it's fine this way too, the hex makes it easy to understand we are testing against a uint16_t, and there's already an assert like that in osmo_iofd_alloc2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 21:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]>
