Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41897?usp=email )
Change subject: bts: use existing API in as_l1_sacch_loop() ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41897/comment/cc4de594_17a2cb2e?usp=email : PS2, Line 2172: private altstep as_l1_sacch_loop(boolean do_apply := false) runs on ConnHdlr { > Isn't it a bit confusing that as_l1_sacch_l1h() has do_apply := true and this > one has do_apply := fa […] I had to change it to `false` because `true` breaks a bunch of testcases, basically all `BTS_Tests.TC_meas_res_*` (and probably more). Prior to this patch, `as_l1_sacch_loop()` did not apply the received TA/PWR values, so `false` keeps the existing behavior unchanged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ab2988152b948e457c3cfa4930df484c170d053 Gerrit-Change-Number: 41897 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
