fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email )
Change subject: trxcon/l1ctl: print an error for uhnandled DATA.req /
TRAFFIC.req
......................................................................
trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req
Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05
---
M src/host/trxcon/src/l1ctl.c
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c
index 0f6bd1b..7ce8c3d 100644
--- a/src/host/trxcon/src/l1ctl.c
+++ b/src/host/trxcon/src/l1ctl.c
@@ -685,9 +685,16 @@
osmo_fsm_inst_dispatch(fi, TRXCON_EV_TX_DATA_REQ, &req);
break;
default:
- if (!traffic && req.link_id == 0x40) /* only for SACCH */
+ if (!traffic && req.link_id == 0x40) { /* only for SACCH */
osmo_fsm_inst_dispatch(fi,
TRXCON_EV_UPDATE_SACCH_CACHE_REQ, &req);
- /* TODO: log an error about uhnandled DATA.req / TRAFFIC.req */
+ break;
+ }
+
+ LOGPFSMSL(fi, g_logc_l1d, LOGL_ERROR,
+ "Unhandled %s Req (chan_nr=0x%02x, link_id=0x%02x,
len=%zu): %s\n",
+ traffic ? "TRAFFIC" : "DATA", req.chan_nr,
req.link_id, req.data_len,
+ msgb_hexdump_l2(msg));
+ break;
}
msgb_free(msg);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05
Gerrit-Change-Number: 41900
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
