Attention is currently required from: daniel, fixeria.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email )

Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX
......................................................................


Patch Set 5:

(4 comments)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/f5378fed_b96ddf75?usp=email
 :
PS5, Line 367: struct osmo_io_fd *iofd
> `const`
Done


https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/451ee954_ddfbf781?usp=email
 :
PS5, Line 379:          memcpy(msgb_put(iofd->pending, msgb_length(in_msg)),
             :             msgb_data(in_msg),
             :
> cosmetic: formatting looks weird here, I find it confusing
Done


File tests/osmo_io/osmo_io_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/1b2f9913_baccf1d2?usp=email
 :
PS5, Line 413: 3
> ```suggestion […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/21354517_a2a0f71c?usp=email
 :
PS5, Line 513: ;
> ```suggestion […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586
Gerrit-Change-Number: 41911
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Fri, 23 Jan 2026 10:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to