pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email )
Change subject: Remove unused private API log_target_create_file_stream()
......................................................................
Remove unused private API log_target_create_file_stream()
This function was never added to the logging.h (despite it was not
static and it was inside libosmocore.map).
It is actually used nowhere, and changing it to static made the compiler
warn about it. Remove it.
Change-Id: Ia30c6b47cfcbb54e7c2c43b877cd9554dc596abf
---
M src/core/libosmocore.map
M src/core/logging.c
2 files changed, 0 insertions(+), 24 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index 3ec322c..cb79843 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -96,7 +96,6 @@
log_set_use_color;
log_target_create;
log_target_create_file;
-log_target_create_file_stream;
log_target_create_gsmtap;
log_target_create_rb;
log_target_create_stderr;
diff --git a/src/core/logging.c b/src/core/logging.c
index ac10d00..479513a 100644
--- a/src/core/logging.c
+++ b/src/core/logging.c
@@ -1278,29 +1278,6 @@
}
#if (!EMBEDDED)
-/*! Create a new file-based log target using buffered, blocking stream output
- * \param[in] fname File name of the new log file
- * \returns Log target in case of success, NULL otherwise
- */
-struct log_target *log_target_create_file_stream(const char *fname)
-{
- struct log_target *target;
-
- target = log_target_create();
- if (!target)
- return NULL;
-
- target->type = LOG_TGT_TYPE_FILE;
- target->tgt_file.out = fopen(fname, "a");
- if (!target->tgt_file.out) {
- log_target_destroy(target);
- return NULL;
- }
- target->output = _file_output_stream;
- target->tgt_file.fname = talloc_strdup(target, fname);
-
- return target;
-}
/*! switch from non-blocking/write-queue to blocking + buffered stream output
* \param[in] target log target which we should switch
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia30c6b47cfcbb54e7c2c43b877cd9554dc596abf
Gerrit-Change-Number: 41893
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
