Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email )
Change subject: Introduce struct osmo_ss7_as_asp_assoc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Sadly I'm not super excited about having a linear list iteration everywehre where so far we simply had an array-index access. The STP may see a rather high rate of messages per second (MSU rate), and anything that slows down the hot path traversed by every message should be as efficient as possible. Ideally any change would make it more efficient, than less so. I might be overly conservative/cautious here, but I'm wondering if we cannot find something more efficient, like a dynamically-sized+reallocated array. After all, the number of ASPs change relatively infrequently compared to the number of MSU we process over time. So making the ASP add/remove more expensive is fine, if the hot path per message has no penalty. It might also be worth doing a simple benchmark to see the actual performance impact vs. my thoughts/expectations here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I149ab467899633ac50cba3e482b2cae02124279d Gerrit-Change-Number: 42105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 09:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
