Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email )
Change subject: RTP: use new abstraction layer instead of direct osmo_ortp ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/4e1d2ae7_1f0c7011?usp=email : PS2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan)); fn_ms_adj is also called here, so feel free to put fn_ms_adj above and modify this function too since fn_ms_adj() always returns a constant value. File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/5297f5b7_63ae0095?usp=email : PS2, Line 590: false, bts->twjit_cfg); align to "(", like done eveyrwhere else. https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/dfdd4abd_08776e0c?usp=email : PS2, Line 641: ia, connect_port); ah so osmo_rtp_socket_connect() actually got a string, and you are converting now this param into an in_addr. Please convert it to a osmo_sockaddr instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf Gerrit-Change-Number: 42166 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 08:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
