Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email )

Change subject: dfu: mainloop: work on a local copy of dfu_state
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File usb_start.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170/comment/f9cb6f50_a3077d71?usp=email
 :
PS2, Line 162:          enum usb_dfu_state last_dfu_state = dfu_state;
> is this assignment atomic actually?
I was under the assumption that any assignment of a (32bit) integer value can 
be considered atomic, as it's just a single load/store?



--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944
Gerrit-Change-Number: 42170
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Mon, 23 Feb 2026 09:41:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to