Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email )

Change subject: stp: Enable tracking of NULL memory context
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File stp/stp_main.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213/comment/75d6bcf3_5f4a607c?usp=email
 :
PS1, Line 220: talloc_enable_null_tracking
I know we already do this in many projects (and not voting against doing this), 
but there must be a reason why it's disabled by default in talloc. One thing 
that comes to my mind is potential performance impact. If this is a concern, we 
may want to enable NULL-tracking conditionally by introducing an environment 
variable.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94
Gerrit-Change-Number: 42213
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 26 Feb 2026 11:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to