Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email )

Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp()
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
> IMHO that function is tcap related (and allows it to quickly find it in tcap 
> related routines files) […]
Ok, maybe best to update the function documentation comment about this notion.


File src/tcap_as_loadshare.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210/comment/bbc0491e_5d1aeb45?usp=email
 :
PS1, Line 293: Destination
unrelated: This should actually say "Source Address", it looks like a 
copy+paste from below



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c
Gerrit-Change-Number: 42210
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 26 Feb 2026 11:49:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to