Attention is currently required from: daniel, fixeria, lynxis lazus, pespin.

Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus,

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder


Change subject: tcap: Support TID with length 1..4
......................................................................

tcap: Support TID with length 1..4

As described in ITU Q.773 4.2.1.3:
"The length of a Transaction ID is 1 to 4 octets."

asn.1 files also describe TIDs the following way:
OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) )
DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) )

Take the chance to avoid asserting based on received external input msg.

Related: SYS#5423
Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845
---
M src/sccp2sua.c
M src/ss7_internal.h
M src/tcap_as_loadshare.c
3 files changed, 40 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran 
refs/changes/12/42212/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845
Gerrit-Change-Number: 42212
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>

Reply via email to