Jenkins Builder has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email )

Change subject: same54: make the default irq handler weak
......................................................................


Patch Set 1:

(125 comments)

File sysmoOCTSIM/gcc/gcc/startup_same54.c:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7c5b3be0_6ff61090?usp=email
 :
PS1, Line 50: void Fallback_Handler(void) __attribute__((weak, 
alias("Dummy_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7593a731_89a977ee?usp=email
 :
PS1, Line 53: void NonMaskableInt_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/45115d33_eae097d1?usp=email
 :
PS1, Line 54: void HardFault_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/965d0e0b_75c658a8?usp=email
 :
PS1, Line 55: void MemManagement_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c0cc460_5047bade?usp=email
 :
PS1, Line 56: void BusFault_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/60cf64be_d25a5762?usp=email
 :
PS1, Line 57: void UsageFault_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dd36cfcf_d7247ebb?usp=email
 :
PS1, Line 58: void SVCall_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/bca87c2f_4a908b4c?usp=email
 :
PS1, Line 59: void DebugMonitor_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6ea9f8c0_bab6c330?usp=email
 :
PS1, Line 60: void PendSV_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dc6eca9c_40ea63f2?usp=email
 :
PS1, Line 61: void SysTick_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/26411d9e_fcde1d22?usp=email
 :
PS1, Line 64: void PM_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9143d18d_85deeccc?usp=email
 :
PS1, Line 65: void MCLK_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/165a3827_aee22d99?usp=email
 :
PS1, Line 66: void OSCCTRL_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* OSCCTRL_XOSCFAIL_0, OSCCTRL_XOSCRDY_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e0b9d5b5_0e299803?usp=email
 :
PS1, Line 67: void OSCCTRL_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* OSCCTRL_XOSCFAIL_1, OSCCTRL_XOSCRDY_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b2df139d_59370f64?usp=email
 :
PS1, Line 68: void OSCCTRL_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* OSCCTRL_DFLLLOCKC, OSCCTRL_DFLLLOCKF,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ab0199b5_9e858bcc?usp=email
 :
PS1, Line 75: void OSC32KCTRL_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1d8306ea_ca1ce471?usp=email
 :
PS1, Line 76: void SUPC_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SUPC_B12SRDY, SUPC_B33SRDY, SUPC_BOD12RDY,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6ad57b20_f695a3fe?usp=email
 :
PS1, Line 79: void SUPC_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SUPC_BOD12DET, SUPC_BOD33DET */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/5973dade_92030be1?usp=email
 :
PS1, Line 80: void WDT_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/21251f90_ce932faa?usp=email
 :
PS1, Line 81: void RTC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/95a54923_7aa9f4df?usp=email
 :
PS1, Line 82: void EIC_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/87f2b882_ad6e44e2?usp=email
 :
PS1, Line 83: void EIC_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7077a18f_86abfb68?usp=email
 :
PS1, Line 84: void EIC_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b17f3795_ad1350e8?usp=email
 :
PS1, Line 85: void EIC_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_3 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6712ab50_4d950894?usp=email
 :
PS1, Line 86: void EIC_4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_4 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3e5e7c96_93a52dc2?usp=email
 :
PS1, Line 87: void EIC_5_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_5 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8d0e6daf_8a3547ea?usp=email
 :
PS1, Line 88: void EIC_6_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_6 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b7b5a495_2b3a590f?usp=email
 :
PS1, Line 89: void EIC_7_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_7 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f162a19e_1bde4439?usp=email
 :
PS1, Line 90: void EIC_8_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_8 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e54ca52a_85e61306?usp=email
 :
PS1, Line 91: void EIC_9_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));  /* EIC_EXTINT_9 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/44405516_e217fcf2?usp=email
 :
PS1, Line 92: void EIC_10_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_10 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a6c1a162_56dcc5d5?usp=email
 :
PS1, Line 93: void EIC_11_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_11 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/5959ea00_2232e9bc?usp=email
 :
PS1, Line 94: void EIC_12_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_12 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a38442e4_49b0c2ee?usp=email
 :
PS1, Line 95: void EIC_13_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_13 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/df18448f_2aea0bbc?usp=email
 :
PS1, Line 96: void EIC_14_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_14 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/50094022_9be71bcd?usp=email
 :
PS1, Line 97: void EIC_15_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EIC_EXTINT_15 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/707d0e7a_99c1ba37?usp=email
 :
PS1, Line 98: void FREQM_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/55b09d54_63333ca1?usp=email
 :
PS1, Line 99: void NVMCTRL_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* NVMCTRL_0, NVMCTRL_1, NVMCTRL_2,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3ebf019f_b5d12e07?usp=email
 :
PS1, Line 102: void NVMCTRL_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* NVMCTRL_10, NVMCTRL_8, NVMCTRL_9 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/bf747d69_6a017154?usp=email
 :
PS1, Line 103: void DMAC_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));    /* DMAC_SUSP_0, DMAC_TCMPL_0, DMAC_TERR_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f3a78e44_189a35b6?usp=email
 :
PS1, Line 104: void DMAC_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));    /* DMAC_SUSP_1, DMAC_TCMPL_1, DMAC_TERR_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a06b2f93_893df89b?usp=email
 :
PS1, Line 105: void DMAC_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));    /* DMAC_SUSP_2, DMAC_TCMPL_2, DMAC_TERR_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e8519909_25f1bb5e?usp=email
 :
PS1, Line 106: void DMAC_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));    /* DMAC_SUSP_3, DMAC_TCMPL_3, DMAC_TERR_3 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a5ef2a83_57670b25?usp=email
 :
PS1, Line 127: void EVSYS_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EVSYS_EVD_0, EVSYS_OVR_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/60274cc9_9009a231?usp=email
 :
PS1, Line 128: void EVSYS_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EVSYS_EVD_1, EVSYS_OVR_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/af7ec2ac_4f85cd70?usp=email
 :
PS1, Line 129: void EVSYS_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EVSYS_EVD_2, EVSYS_OVR_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6654e40c_01dca960?usp=email
 :
PS1, Line 130: void EVSYS_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EVSYS_EVD_3, EVSYS_OVR_3 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c1080b11_d5fa102e?usp=email
 :
PS1, Line 131: void EVSYS_4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* EVSYS_EVD_10, EVSYS_EVD_11, EVSYS_EVD_4,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/18d28228_76e73646?usp=email
 :
PS1, Line 137: void PAC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/06afdb11_5113400c?usp=email
 :
PS1, Line 138: void RAMECC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6c11a7de_8003bcf2?usp=email
 :
PS1, Line 139: void SERCOM0_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM0_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ffc8c6e9_0fa40f47?usp=email
 :
PS1, Line 140: void SERCOM0_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM0_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f6f6aefe_afa71541?usp=email
 :
PS1, Line 141: void SERCOM0_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM0_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4acaf16c_c5a4c347?usp=email
 :
PS1, Line 144: void SERCOM1_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM1_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/be8a4aec_c8bf1539?usp=email
 :
PS1, Line 145: void SERCOM1_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM1_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9e62f79f_731528cd?usp=email
 :
PS1, Line 146: void SERCOM1_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM1_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c215c01_ab3ffd29?usp=email
 :
PS1, Line 149: void SERCOM2_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM2_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f177fe4e_924c3bc9?usp=email
 :
PS1, Line 150: void SERCOM2_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM2_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ef87b4e5_3fde3364?usp=email
 :
PS1, Line 151: void SERCOM2_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM2_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/336fc234_2a3323ea?usp=email
 :
PS1, Line 154: void SERCOM3_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM3_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/08b6c62a_6e698f6b?usp=email
 :
PS1, Line 155: void SERCOM3_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM3_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c473b6ca_aa1c8fcc?usp=email
 :
PS1, Line 156: void SERCOM3_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM3_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a95e29c4_2f86b867?usp=email
 :
PS1, Line 160: void SERCOM4_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM4_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1f3a2ba3_c045380d?usp=email
 :
PS1, Line 161: void SERCOM4_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM4_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3a1728b6_180d3af6?usp=email
 :
PS1, Line 162: void SERCOM4_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM4_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/07e83c7a_8eb8be4e?usp=email
 :
PS1, Line 167: void SERCOM5_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM5_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c5a9aeb_aa21b175?usp=email
 :
PS1, Line 168: void SERCOM5_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM5_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c79342b4_1943633b?usp=email
 :
PS1, Line 169: void SERCOM5_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM5_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3e5713a3_5f2fd3c6?usp=email
 :
PS1, Line 174: void SERCOM6_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM6_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/77bcb4f5_8b7cd725?usp=email
 :
PS1, Line 175: void SERCOM6_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM6_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ad44dda8_870955b1?usp=email
 :
PS1, Line 176: void SERCOM6_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM6_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c9257529_5c4e1cd8?usp=email
 :
PS1, Line 181: void SERCOM7_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM7_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b000a91e_f99a1a0e?usp=email
 :
PS1, Line 182: void SERCOM7_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM7_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/125c220c_babe8f72?usp=email
 :
PS1, Line 183: void SERCOM7_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* SERCOM7_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b3261d79_dbab5ac9?usp=email
 :
PS1, Line 188: void CAN0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7e9aa3d4_a75648de?usp=email
 :
PS1, Line 191: void CAN1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1e339bdd_44b7fad3?usp=email
 :
PS1, Line 210: void USB_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* USB_SOF_HSOF */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4b2d508b_19efa4b4?usp=email
 :
PS1, Line 211: void USB_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* USB_TRCPT0_0, USB_TRCPT0_1, USB_TRCPT0_2,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/da02e334_2e44c34b?usp=email
 :
PS1, Line 214: void USB_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* USB_TRCPT1_0, USB_TRCPT1_1, USB_TRCPT1_2,
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/82b3cd23_afd2703f?usp=email
 :
PS1, Line 219: void GMAC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8db9fa10_aad4936a?usp=email
 :
PS1, Line 225: void TCC0_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7e2ce1eb_4a5e06ec?usp=email
 :
PS1, Line 226: void TCC0_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4f91a270_824f1c0f?usp=email
 :
PS1, Line 227: void TCC0_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/83f9eab7_d8a42722?usp=email
 :
PS1, Line 228: void TCC0_4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_3 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/aa9390d4_b413fc89?usp=email
 :
PS1, Line 229: void TCC0_5_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_4 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3daa52f3_d3d7780d?usp=email
 :
PS1, Line 230: void TCC0_6_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC0_MC_5 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/d369e208_128a6c21?usp=email
 :
PS1, Line 235: void TCC1_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC1_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dcd69ec6_f35ff30f?usp=email
 :
PS1, Line 236: void TCC1_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC1_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6c815951_8d216d16?usp=email
 :
PS1, Line 237: void TCC1_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC1_MC_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8e872303_a0d3ccda?usp=email
 :
PS1, Line 238: void TCC1_4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC1_MC_3 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e5fc883c_bee8aba1?usp=email
 :
PS1, Line 243: void TCC2_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC2_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fa30f58b_bf4c63f5?usp=email
 :
PS1, Line 244: void TCC2_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC2_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c371585a_b67f7f1a?usp=email
 :
PS1, Line 245: void TCC2_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC2_MC_2 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fdeeb371_b179173f?usp=email
 :
PS1, Line 251: void TCC3_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC3_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/353422b4_6b1a4918?usp=email
 :
PS1, Line 252: void TCC3_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC3_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a891a8e5_92ab7e02?usp=email
 :
PS1, Line 259: void TCC4_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC4_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/482239ba_1a47891f?usp=email
 :
PS1, Line 260: void TCC4_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* TCC4_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/2de26dd9_ef447ab0?usp=email
 :
PS1, Line 262: void TC0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/d1ff249f_3f6f581f?usp=email
 :
PS1, Line 263: void TC1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/33cbc806_9a92fa3c?usp=email
 :
PS1, Line 264: void TC2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fd7655ce_1973fd71?usp=email
 :
PS1, Line 265: void TC3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/88b03540_b607585e?usp=email
 :
PS1, Line 267: void TC4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9d3ebcbf_517a5b24?usp=email
 :
PS1, Line 270: void TC5_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/35eed653_c96135c8?usp=email
 :
PS1, Line 273: void TC6_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1a2ab462_adf7bcf0?usp=email
 :
PS1, Line 276: void TC7_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/38d82061_4f3622de?usp=email
 :
PS1, Line 280: void PDEC_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* PDEC_MC_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e04794c9_f41b8d0f?usp=email
 :
PS1, Line 281: void PDEC_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* PDEC_MC_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9f208cd3_31b9784c?usp=email
 :
PS1, Line 282: void ADC0_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* ADC0_OVERRUN, ADC0_WINMON */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/12a2634c_e89f1094?usp=email
 :
PS1, Line 283: void ADC0_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* ADC0_RESRDY */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8d4a7d9a_52200f02?usp=email
 :
PS1, Line 284: void ADC1_0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* ADC1_OVERRUN, ADC1_WINMON */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cbee2fc6_d5074995?usp=email
 :
PS1, Line 285: void ADC1_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* ADC1_RESRDY */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cf1adcfc_806c2ebb?usp=email
 :
PS1, Line 286: void AC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/59ab2f28_fc8ad539?usp=email
 :
PS1, Line 290: void DAC_1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* DAC_EMPTY_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/72dd9cd3_c0388b90?usp=email
 :
PS1, Line 291: void DAC_2_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* DAC_EMPTY_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/625cecf3_063817ac?usp=email
 :
PS1, Line 292: void DAC_3_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* DAC_RESRDY_0 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f1fe609b_23bddb0e?usp=email
 :
PS1, Line 293: void DAC_4_Handler(void) __attribute__((weak, 
alias("Fallback_Handler"))); /* DAC_RESRDY_1 */
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1ba5273b_963f79c1?usp=email
 :
PS1, Line 295: void I2S_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/73b48863_d3499c21?usp=email
 :
PS1, Line 297: void PCC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/2c1f3f19_eb31ac04?usp=email
 :
PS1, Line 298: void AES_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c7449c9e_42f64738?usp=email
 :
PS1, Line 299: void TRNG_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/0408df34_7c30b046?usp=email
 :
PS1, Line 301: void ICM_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cbae3646_85105aa1?usp=email
 :
PS1, Line 304: void PUKCC_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/70c56914_cb236d04?usp=email
 :
PS1, Line 306: void QSPI_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c8994982_36c9d1a0?usp=email
 :
PS1, Line 308: void SDHC0_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/24c69143_f9055989?usp=email
 :
PS1, Line 311: void SDHC1_Handler(void) __attribute__((weak, 
alias("Fallback_Handler")));
function definition argument 'void' should also have an identifier name



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 26 Feb 2026 17:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to