Attention is currently required from: Hoernchen, laforge.

lynxis lazus has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email )

Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

File src/bankd/bankd_main.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/6d48ac94_f29f2a7d?usp=email
 :
PS3, Line 826:          return -107;
Maybe this is a more general question and not so much related to this commit.
But when to drop the client connection?
If we return here -107, the bankd will close the client.

But isn't this quite a harsh behavior? The quite innocent client just passed 
data from the other end.



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I5c9f1143b85470234acd2e2ffe3e0cf72bd2ae43
Gerrit-Change-Number: 42231
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to