Attention is currently required from: Thorkell Thorkelsson, falconia, pespin.

fixeria has posted comments on this change by Thorkell Thorkelsson. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email )

Change subject: tch: fix RTP clock not ticking for unhandled payload types
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File src/osmo-bts-sysmo/tch.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/eb5c5f1e_5a3fda38?usp=email
 :
PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented
I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not 
handled in the switch statement. Could you please explain why are you removing 
it?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c
Gerrit-Change-Number: 42244
Gerrit-PatchSet: 2
Gerrit-Owner: Thorkell Thorkelsson <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: Thorkell Thorkelsson <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sun, 01 Mar 2026 15:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to