Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42237?usp=email )
Change subject: docs/smpp-ota-tool: Add documentation/tutorial ...................................................................... Patch Set 2: (10 comments) File docs/smpp-ota-tool.rst: https://gerrit.osmocom.org/c/pysim/+/42237/comment/79856fe5_73b4eaf0?usp=email : PS1, Line 5: cards > an eUICC must not be a card, in fact most often it is not. […] I think SIM/UICC/eUICC should cover all variations. (As far as I know classic SIMs were already able to receive OTA-SMS messages) https://gerrit.osmocom.org/c/pysim/+/42237/comment/495d3de6_6fa25324?usp=email : PS1, Line 6: SMPP : server > "... SMPP server (such as a production SMSC of a live cellular network) as > well." […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/ede38d0a_0f4b8232?usp=email : PS1, Line 17: a se > it's not "a set" but "sets of keys".. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/54ddfa34_75b7b3f8?usp=email : PS1, Line 17: card > we have many more instances of "card" in the document, it seems. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/c44f2edd_826ab9f7?usp=email : PS1, Line 26: The KIK is not used in the scope of SCP80. > oh, are you sure? That means you cannot deploy new SCP80 (or other) keys via > SCP80? I would have as […] I have asked myself the same question but I could not find any reference to KIK in ETSI TS 102 225 This lead me to the assumption that KIK is not available in SCP80. When I look at Table 1. There is only "KIc" and "KID", not "KIK" or anything. We also only have the sections "Coding of KIc" and "Coding of KID". But I have had closer look at this again now: ETSI TS 102 226, section 8.2.1.5 hints towards that the KIK (DEK) is implicitly selected. KIc and KID must be the same numbers anyway (mixing keys from different keysets is forbidden, but SCP80 would technically allow it). The spec says: "The transport security keys (i.e. KIc/KID) used to secure the Response Packet shall be the same as the ones of the Command Packet containing the PUT KEY command.", so when KIc/KID is 1, then KIK is also 1. and so on. So, I think we should write this paragraph a bit differently... (I still have problems to understand to which layer the KIK actually belongs to. To me it seems that it is more or less something that is specific to put_key. If this is true it should not be mentioned in any of those specs and only be discussed in the global platform spec where put_key is specified.) https://gerrit.osmocom.org/c/pysim/+/42237/comment/e8a9027a_153c6f3a?usp=email : PS1, Line 28: programmed into the issuer security domain (ISD) > the keyset doesn't have to be in the ISD. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/e63b30fb_1f32f751?usp=email : PS1, Line 84: A0A40000027F20 > might be worth using formatting instructions to use monospaced font for all > APDUs or other hex-strin […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/c4c34553_7cc37059?usp=email : PS1, Line 86: is received by the SIM RFM application and then executed. This method poses some limitations that have to be taken into > might be worth stating that he SIM RFM application is "on the card" Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/5be08627_e556b4b9?usp=email : PS1, Line 115: : To prevent this, we may include a replay protection counter within the message. In this case, the MSL indicates that a : replay protection counter is not required. However, to extended the security of our messages, we may chose to use a : counter anyway. In the following example, we will encode a counter value of 100. We will instruct the card to make sure : that the value we send is higher than the counter value that is currently stored in the card. > it might be worth mentioning at some earlier point that the MSL of the card > may be different for dif […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/f516e49f_69754f5e?usp=email : PS1, Line 162: overlap > "... it will not wrap on overflow ... Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 Gerrit-Change-Number: 42237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 12:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
