Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 3: (1 comment) File CommonLibs/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/096fab28_b81b36a5?usp=email : PS3, Line 56: lib_LTLIBRARIES = libcommon.la > By doing this, you are installing the libraries, which is something we don't > wanna do. This is not intended for the regular native build. The idea is to enable this only for the Emscripten/WebAssembly build, where we intentionally combine parts of `osmo-bts-trx` and `osmo-trx` into a single target. In that scenario, we are not installing system-wide libraries in the traditional sense — we just need proper linkage metadata to consume those components during the unified build. For normal native builds, nothing would change and no additional libraries would be installed. If installing the libraries is not acceptable even conditionally, perhaps you could suggest a preferred way to make the internal components linkable when building `osmo-bts-trx` and `osmo-trx` together as a single target? I'm open to structuring it in a way that fits the project’s expectations. As an alternative, I could create a separate library specifically for the Emscripten build that would include only the source files required from osmo-trx. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 17:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
