Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/6319/1//COMMIT_MSG Commit Message: Line 18: OS#2710 in order to be easily picked up by robots, please put this on the same line. Also drop the blank line between this and the Change-Id. https://gerrit.osmocom.org/#/c/6319/1/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: Line 237: .call_id = 12345, wait, what? If it's correct, explain in a code comment? Line 240: osmo_strlcpy(mgcp_msg.endpoint, mgcp_ctx->rtp_endpoint, sizeof(mgcp_msg.endpoint)); > This change removes a check for truncation. Is this intended? (fine difference that it's osmo_strlcpy(), but it does follow the BSD strlcpy signature, so I agree with stsp that truncation still deserves a handle_error(); and probably that case also deserves a unit test of sorts?) -- To view, visit https://gerrit.osmocom.org/6319 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee3e446b6689626516f01c521abe3d4603cd3e13 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-HasComments: Yes
