Patch Set 5: (2 comments)
https://gerrit.osmocom.org/#/c/6619/5/CommonLibs/trx_vty.h File CommonLibs/trx_vty.h: Line 7: struct trx_ctx { > Please add a comment with brief description of this Initially I thought it would make sesne to move the Trasnciever, RadioDevice and RadioInterface pointers in here, but I'm still unsure if it's finally going to handle more stuff because in order to introduce those I'd need to compile everything to c++. I'm still unsure if it makes sense to slowly try to isolate c++ parts in favor of c or just try to compile everything as c++. https://gerrit.osmocom.org/#/c/6619/5/Transceiver52M/osmo-trx.cpp File Transceiver52M/osmo-trx.cpp: Line 345: config->config_file = (char *)DEFAULT_CONFIG_FILE; > Why do we need this cast? Not in C++ apparently, I was hitting this compiler warning: https://stackoverflow.com/questions/20944784/why-is-conversion-from-string-constant-to-char-valid-in-c-but-invalid-in-c -- To view, visit https://gerrit.osmocom.org/6619 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad Gerrit-PatchSet: 5 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
