Patch Set 6: (2 comments)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h File include/osmocom/gsm/gsm0808_utils.h: Line 44: /* Parsed Location Area Code and Cell Identity (CELL_IDENT_LAC_AND_CI) */ documentation in libraries should generally use Doxygen formatting so it gets automatically picked up and published, in case of libosmogsm at http://ftp.osmocom.org/api/latest/libosmocore/gsm/html/ Line 70: uint8_t id_discr; this field is neither a union nor is there a comment on how it is used/composed. -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
