Patch Set 5: (3 comments)
https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: Line 58: import time What about moving the import to the top with the other ones? Line 88: Extra line, can be removed Line 107: def start_mobile(self, loop): Can now be called start(), as it's already in the mobile class. -- To view, visit https://gerrit.osmocom.org/6917 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
