Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6388 to look at the new patch set (#3). VLR: fix potential NULL dereference The vlr_subscr_get() can return NULL if its argument is NULL (which isn't checked for) so before dereferencing it's result we should check for it. Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91 --- M src/libmsc/gsm_04_08.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/88/6388/3 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 995bbf6..f87a4c6 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -3721,8 +3721,10 @@ struct vlr_subscr *vsub) { struct gsm_subscriber_connection *conn = msc_conn_ref; + OSMO_ASSERT(vsub); OSMO_ASSERT(!conn->vsub); conn->vsub = vlr_subscr_get(vsub); + OSMO_ASSERT(conn->vsub); conn->vsub->cs.attached_via_ran = conn->via_ran; } -- To view, visit https://gerrit.osmocom.org/6388 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de>