Patch Set 10: (2 comments)
https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS10, Line 1280: ; : lai = (struct osmo_location_area_id) > why not simply have the '=' one line above, no typecast and no need to rest weird, makes me wonder "what was my motivation" https://gerrit.osmocom.org/#/c/6668/10/src/osmo-bsc/osmo_bsc_vty.c File src/osmo-bsc/osmo_bsc_vty.c: Line 242: > whitespace, not critical vim has a way of removing these obsolete tabs, but for some reason it doesn't always work. That in combination with my external patch colorizer .. I should teach it to also mark whitespace errors. -- To view, visit https://gerrit.osmocom.org/6668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa Gerrit-PatchSet: 10 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
