Patch Set 1:
> I would really hope there is another method than to add a
> configure.ac flag for every compiler option / CFLAG we ever want to
> sue from our continuous integration setup.
It's not just one CFLAG here, there is a "fine-tuned" combination of warnings
we don't want to see as errors:
-Werror -Wno-error=deprecated -Wno-error=deprecated-declarations
-Wno-error=cpp
We can put it in all the jenkins.sh files, sure. But I also want to be able to
conveniently test this locally. So what do I do, copy-paste from the jenkins.sh?
For me what works best is the explicit ./configure argument, since (personally)
I already have some infrastructure around to manage configure arguments (in
osmo-dev.git).
So I think yes, this is the right place.
* It's about compilation = the realm of configure.ac
* We already adjust a lot of CFLAGS in configure.ac.
* I can conveniently run the exact -Werror definitions that we use to pass or
reject a new patch, by just remembering --enable-werror.
* ./configure --help provides "online doc" for -Werror and gives an explanation
of why certain flags are set.
* It's not harmful to have that option.
(I'd actually prefer to have them defined only once, like in libosmocore, for
all other projects, but we don't have a configure.ac sharing mechanism in
place.)
Do you guys have another suggestion that gets me similar convenience?
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-HasComments: No
