Patch Set 3: Code-Review+1 (3 comments)
some comments, none really important https://gerrit.osmocom.org/#/c/7019/3/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 11: repo: (our other yml files call this "repos" -- I saw it was also called "repos" in an earlier patch set. Any particular reason to drop the 's' and be different from the other files?) Line 22: reverse-job: master-openbsc what, "reverse"? un-build the binaries?? :) How about "triggered-by" (my favorite) or if you want to match jjb naming "triggers-reverse" Line 66: - gsmtester_build_branch: (I don't understand what's going on here, but if you say it's correct...) -- To view, visit https://gerrit.osmocom.org/7019 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes