Patch Set 7: Code-Review+1 (2 comments)
I'm not sure I overlook the bigger picture, but do go ahead. https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/__init__.py File src/osmo_ms_driver/__init__.py: Line 5: # Authors: D. Lazlo Sitzer <dlsit...@sysmocom.de> > That's not how copyright works but you have an expert in your proximity but Also, frankly, this is just a list of authors, the copyright is two lines further up. https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/cdf.py File src/osmo_ms_driver/cdf.py: Line 29: y-axis we have the percentage (from 0.0 to 1.0) of how many technically from 0..1 would not be a percentage as the word implies the 0..100 range; more like a fraction or factor :) -- To view, visit https://gerrit.osmocom.org/6230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3 Gerrit-PatchSet: 7 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
