Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/9220 )
Change subject: remove redundant unconditional PKG_CHECK_MODULES for libsmpp
......................................................................
Patch Set 1:
I think the commit you are fixing added this:
smpp_mirror_CFLAGS = \
$(LIBOSMOCORE_CFLAGS) \
$(LIBSMPP34_CFLAGS) \
$(NULL)
which means if smpp is not checked unconditionally, it will fail because
LIBSMPP34_CFLAGS will not be set.
You need to conditionally build that one. Check also if there are more related
changes required please.
--
To view, visit https://gerrit.osmocom.org/9220
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13
Gerrit-Change-Number: 9220
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 13:57:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
