Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9216 )

Change subject: mgcp: switch to new osmux output APIs
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I have no idea about this API

https://gerrit.osmocom.org/#/c/9216/1/src/libosmo-mgcp/mgcp_osmux.c
File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/#/c/9216/1/src/libosmo-mgcp/mgcp_osmux.c@553
PS1, Line 553:                                                  
scheduled_tx_net_cb, endp);
(weird indenting choice ... we typically align with '(' or use one tab)



--
To view, visit https://gerrit.osmocom.org/9216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0705aa4dc4b02eaff4d6030795243e6720f7fddf
Gerrit-Change-Number: 9216
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 15:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to