Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9223 )

Change subject: contrib: common: create_bin_tgz supports sbin dir now
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/9223/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9223/1//COMMIT_MSG@7
PS1, Line 7: contrib: common: create_bin_tgz supports sbin dir now
"add support for sbin dir binaries"

And add the reason why: which of our packages installs sbin binaries!?


https://gerrit.osmocom.org/#/c/9223/1/contrib/jenkins-build-common.sh
File contrib/jenkins-build-common.sh:

https://gerrit.osmocom.org/#/c/9223/1/contrib/jenkins-build-common.sh@146
PS1, Line 146:         if [ ! -d "$prefix_real"/$bindir ]; then return; fi
since it is now a shell var, include it in the quotes

  "$prefix_real/$bindir"

not that we would ever have bin dirs with spaces, it's just nitpicking.


https://gerrit.osmocom.org/#/c/9223/1/contrib/jenkins-build-common.sh@168
PS1, Line 168:   wanted_binaries_bin="$1"
so now all callers need to pass binaries in quotes, including spaces in the 
quotes... well, ok then.



--
To view, visit https://gerrit.osmocom.org/9223
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I562721af82e481e926ee65dbcd9dcc5b55057ae8
Gerrit-Change-Number: 9223
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 16:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to