Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9258 )
Change subject: WIP: tests: remove gmm unit tests ...................................................................... Patch Set 1: I think Neels might have a different opinion, but I agree that the tests in TTCN-3 are much more maintainable than unit tests that use hard-coded byte arrays that are impossible to be parsed/edited by a human being. Yes, the unit tests execute much quicker. Which is maybe a reason/motivation to make the TTCN-3 test execute quicker, and to think about moving the tests from the osmo-ttcn3-hacks.git into the individual osmo-* repositories? In any case, we cannot loose test coverage. So removing the unit tests can only be done once it is ensured that all tests we used to have here are present in SGSN_Tests.ttcn. -- To view, visit https://gerrit.osmocom.org/9258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac1c8854b5ea4aa03279990390ebc110c979aac2 Gerrit-Change-Number: 9258 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 23 May 2018 16:22:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
