Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9279 )
Change subject: add bsc_stubs.h to workaround linking hell for utils and tests ...................................................................... Patch Set 1: tldr: yes, utterly temporary. I have often been aching to resolve that madness where libbsc cannot compile without osmo-bsc. The unknown here is osmo-bsc_nat -- how will we resurrect it? Which parts of libbsc will be shared? The knowns are: various tests / utility programs use parts of libbsc. I regularly hit linking spaghetti that make no sense at all, like bs11_config requiring an implementation of bsc_send_handover_required(), and it really would help to sort things into their little realms. But it needs time spent to figure out what code is actually shared. So far my conclusion was that it would be nice but I don't have the luxury to sort it now, yet. The interdependency started with the gscon living in libbsc, but directly calling osmo_bsc_sigtran_open() and osmo_bsc_sigtran_send() implemented in src/osmo-bsc/. Most likely the entire gscon does not apply to osmo-bsc_nat at all, but its allocation is tightly glued to the gsm_subscriber_connection now. So there's like a steel bar built through the open fire door... -- To view, visit https://gerrit.osmocom.org/9279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000be689ed071aced1a085284f924a7e77e5656d Gerrit-Change-Number: 9279 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Fri, 25 May 2018 11:21:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
