Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/9538
Change subject: bsc_subscr_conn_fsm: BSC must not release SCCP connection
......................................................................
bsc_subscr_conn_fsm: BSC must not release SCCP connection
3GPP TS 48.006 section 9.2 states clearly that any SCCP connection
release must be initiated by the MSC.
for bsc_subscr_conn_fsm, this means that even after sending the
BSSMAP CLEAR COMPLETE, we must not terminate the FSM, as this would
cause a N-DISCONNET.req to be sent to the stack for the associated
SCCP connection.
The bsc_subscr_conn_fsm instances will hence stay alive until the MSC
eventually decises to release them.
Change-Id: Iaaca220b598609b77b600fcfc2f9a78b221c1fbb
Closes: OS#3331
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/9538/1
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index bd652f0..4f09ae6 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -729,7 +729,9 @@
case GSCON_EV_RSL_CLEAR_COMPL:
resp = gsm0808_create_clear_complete();
sigtran_send(conn, resp, fi);
- osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, data);
+ /* we cannot terminate the FSM here, as that would send
N-DISCCONNET.req
+ * and 3GPP TS 48.006 Section 9.2 clearly states that SCCP
connections must
+ * always be released from the MSC side*/
break;
default:
OSMO_ASSERT(false);
--
To view, visit https://gerrit.osmocom.org/9538
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaaca220b598609b77b600fcfc2f9a78b221c1fbb
Gerrit-Change-Number: 9538
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
