Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9739 )
Change subject: VLR: reject overlong IMSIs in ID RESP messages ...................................................................... Patch Set 1: > I'd prefer getting the return error code paths introduced in this > commit instead of only half fixing the issue and adding more TODOs. > > Is there something I'm not aware of which prevents you from adding > those? It is just a question of how much to chew off in one bite. Probably the biggest item to figure out is how the LU FSM should handle this error condition. -- To view, visit https://gerrit.osmocom.org/9739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I785c994f41a646d8d83d3d82f5a9ae6b572eb641 Gerrit-Change-Number: 9739 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 16:54:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
