Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9671 )
Change subject: large refactoring: use FSMs for lchans; add inter-BSC HO ...................................................................... Patch Set 13: This latest patch set: There was an error about the MultiRate Config IE. Hence add an error message that warns against a zero length in the MultiRate Config. Compose the MultiRate Config for AMR codecs, like the old implementation did. Note that https://gerrit.osmocom.org/9856 adds a ttcn3-bsc-test that catches the MR Config IE error. mgw_endpoint_fsm.c: tweak logging, add LOG_CI_VERB() which prints an IP address and port only if present, and use that where applicable. (I saw weird logging for CRCX, which typically has no IP:port and looked like "Sending CRCX :0" from empty hostname and zero port) There are still cosmetic bits and testing pending here. -- To view, visit https://gerrit.osmocom.org/9671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82e3f918295daa83274a4cf803f046979f284366 Gerrit-Change-Number: 9671 Gerrit-PatchSet: 13 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jul 2018 22:49:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
