Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9873 )
Change subject: sniffer USB: implement USB communication and send parsed messages ...................................................................... Patch Set 5: (1 comment) common USB message header initialize function added https://gerrit.osmocom.org/#/c/9873/5/firmware/libcommon/source/sniffer.c File firmware/libcommon/source/sniffer.c: https://gerrit.osmocom.org/#/c/9873/5/firmware/libcommon/source/sniffer.c@206 PS5, Line 206: struct simtrace_msg_hdr *usb_msg_header; : usb_msg->l1h = msgb_put(usb_msg, sizeof(*usb_msg_header)); : usb_msg_header = (struct simtrace_msg_hdr *) usb_msg->l1h; : memset(usb_msg_header, 0, sizeof(*usb_msg_header)); : usb_msg_header->msg_class = SIMTRACE_MSGC_SNIFF; : usb_msg_header->msg_type = SIMTRACE_MSGT_SNIFF_CHANGE; : usb_msg->l2h = usb_msg->l1h + sizeof(*usb_msg_header) > this kind of block seems to repeat over the file. […] fixed -- To view, visit https://gerrit.osmocom.org/9873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7817480705f2124b08c1ff9a8826558b6d8b2b Gerrit-Change-Number: 9873 Gerrit-PatchSet: 5 Gerrit-Owner: Kévin Redon <kre...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Kévin Redon <kre...@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jul 2018 15:12:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
