Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9946 )
Change subject: host sniff: add functions to print flags ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/9946/4/host/simtrace2-sniff.c File host/simtrace2-sniff.c: https://gerrit.osmocom.org/#/c/9946/4/host/simtrace2-sniff.c@97 PS4, Line 97: struct flag_meaning_t { we typically use 'struct value_string' here and the corresponding 'get_value_string() and 'get_string_value()' functions from libosmocore. Unless you need something those functions don't provide, please use the existing ones. -- To view, visit https://gerrit.osmocom.org/9946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c0a4790662bcc64db5ff03adcc033836e16ad0 Gerrit-Change-Number: 9946 Gerrit-PatchSet: 4 Gerrit-Owner: Kévin Redon <kre...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 19:57:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
