Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/10212
Change subject: sniff: fix ATR checksum calculation ...................................................................... sniff: fix ATR checksum calculation this issue also cause the sent ATR to be empty Change-Id: I6edff7aeb3185c835656acde75886fb6c90c0582 --- M firmware/libcommon/source/sniffer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/12/10212/1 diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 5cf96fd..c57877f 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -505,7 +505,7 @@ if (ATR_S_WAIT_TCK == atr_state) { uint8_t ui; uint8_t checksum = 0; - for (ui = 1; ui < atr_i; atr_i++) { + for (ui = 1; ui < atr_i; ui++) { checksum ^= atr[ui]; } if (checksum) { -- To view, visit https://gerrit.osmocom.org/10212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6edff7aeb3185c835656acde75886fb6c90c0582 Gerrit-Change-Number: 10212 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kre...@sysmocom.de>