Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10113 )
Change subject: import gsup_client.c as new libosmo-gsup-client ...................................................................... Patch Set 4: (3 comments) Please interpret all my comments just as notes for the further comments, I got the idea of having a clean import... https://gerrit.osmocom.org/#/c/10113/4/.gitignore File .gitignore: https://gerrit.osmocom.org/#/c/10113/4/.gitignore@25 PS4, Line 25: *.pc Also makes sense to ignore gsup-test-client binary... https://gerrit.osmocom.org/#/c/10113/4/include/osmocom/gsupclient/gsup_client.h File include/osmocom/gsupclient/gsup_client.h: https://gerrit.osmocom.org/#/c/10113/4/include/osmocom/gsupclient/gsup_client.h@1 PS4, Line 1: GPRS s/GPRS/Generic/ according to libosmocore's documentation. Probably, makes sense to do it in a separate commit due to 'as-clean-as-possible import'. Or even completely drop this license header, as we usually don't have them in *.h files... https://gerrit.osmocom.org/#/c/10113/4/src/gsupclient/Makefile.am File src/gsupclient/Makefile.am: https://gerrit.osmocom.org/#/c/10113/4/src/gsupclient/Makefile.am@16 PS4, Line 16: noinst_PROGRAMS = gsup-test-client Do we really need this? Does anybody use this binary? -- To view, visit https://gerrit.osmocom.org/10113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief50054ad135551625b684ed8a0486f7af0b2940 Gerrit-Change-Number: 10113 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 11:53:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
