Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10415 )
Change subject: send TCH/F fill frames in DTX mode (WIP) ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10415/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/#/c/10415/1/src/common/l1sap.c@676 PS1, Line 676: 52, 53, 54, 55, 56, 57, 58, 59 again also here: We are opearating at _block_ level at the l1sap level, not a burst level. So we will ever only see a RTS.ind for 52 and 56 here, and the PHY will transmit at fn%26 == (52.53,54,55 and 56,57,58,59 respectively). So if you want to be super careful, I would check if it's 52 or 56, and could OSMO_ASSERT if it's ever any of the other numbers above, which should never happen, as TCH/F blocks are defined to start at 0,4,8,13,17,21 (modulo 26), which means 0,4,8,13,17,21, 26,30,34,38,47, 52,56,60,65,73, 78,82,86,91,99 -- To view, visit https://gerrit.osmocom.org/10415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bff00b8cf41dc1b0e6e668173bebce23be0d253 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Fri, 10 Aug 2018 07:19:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
