Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/10431
Change subject: layer23: fix unaligned store in osmo_send_l1()
......................................................................
layer23: fix unaligned store in osmo_send_l1()
This fixes the following alignment issue uncovered by asan:
l1l2_interface.c:169:7: runtime error: store to misaligned address
0x61600001ab99 for type 'uint16_t', which requires 2 byte alignment
0x61600001ab99: note: pointer points here
00 00 00 00 00 00 06 0a 01 19 19 40 18 00 07 00 01 03 49 06 15 00 40 01 c0
00 00 00 00 00 00 00
^
Change-Id: Ie65b428107d35bac99bc870fdbc4dc509ca2f33c
---
M src/host/layer23/src/common/l1l2_interface.c
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/31/10431/1
diff --git a/src/host/layer23/src/common/l1l2_interface.c
b/src/host/layer23/src/common/l1l2_interface.c
index d89995d..956279d 100644
--- a/src/host/layer23/src/common/l1l2_interface.c
+++ b/src/host/layer23/src/common/l1l2_interface.c
@@ -157,16 +157,13 @@
int osmo_send_l1(struct osmocom_ms *ms, struct msgb *msg)
{
- uint16_t *len;
-
DEBUGP(DL1C, "Sending: '%s'\n", osmo_hexdump(msg->data, msg->len));
if (msg->l1h != msg->data)
LOGP(DL1C, LOGL_ERROR, "Message L1 header != Message Data\n");
-
+
/* prepend 16bit length before sending */
- len = (uint16_t *) msgb_push(msg, sizeof(*len));
- *len = htons(msg->len - sizeof(*len));
+ msgb_push_u16(msg, msg->len);
if (osmo_wqueue_enqueue(&ms->l2_wq, msg) != 0) {
LOGP(DL1C, LOGL_ERROR, "Failed to enqueue msg.\n");
--
To view, visit https://gerrit.osmocom.org/10431
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie65b428107d35bac99bc870fdbc4dc509ca2f33c
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
