Tobias Mädel (manawyrm) has posted comments on this change. ( https://gerrit.osmocom.org/10452 )
Change subject: sdp: remove htonl() from in_addr ...................................................................... Patch Set 2: Code-Review-1 > Patch Set 2: Code-Review-1 > > (1 comment) Yep. We discussed this in IRC and I'm now also against merging this. I'll fix this properly and submit a new patch. -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel (manawyrm) <osmocom.acco...@tbspace.de> Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Tobias Mädel (manawyrm) <osmocom.acco...@tbspace.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: kamilner <kamil...@sslconsult.com> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 15:03:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
