Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10163 )
Change subject: ipa: if there are PCs in the msg, use them for routing ...................................................................... Patch Set 1: to clarify why I think the current code needs fixing: the function patch_sccp_with_pc() writes point-codes into the message only if there aren't any yet. I think we should rather always overwrite, or fail on mismatch. right? -- To view, visit https://gerrit.osmocom.org/10163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I157c43a5dc12f6e24828efef1dceac246497e313 Gerrit-Change-Number: 10163 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Aug 2018 15:15:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
