Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10728 )
Change subject: Implement Cause Mapping ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/10728/2/src/call.h File src/call.h: https://gerrit.osmocom.org/#/c/10728/2/src/call.h@46 PS2, Line 46: int cause; as this is just an integer number, and there's no reference to an enum or any type, or a comment, it's hard to know what kind of number range / type / ... is used here. I would appreciate at least a comment pointing to the relevant table/spec/header/... https://gerrit.osmocom.org/#/c/10728/2/src/call.h@134 PS2, Line 134: cause same here. -- To view, visit https://gerrit.osmocom.org/10728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b80dff7e583cd6fff2b662bc6cc4bad3f81cd4 Gerrit-Change-Number: 10728 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Fri, 31 Aug 2018 16:17:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
