Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10754 )
Change subject: fix mgcp_verify_ci(): off-by-one in max len check ...................................................................... Patch Set 1: Code-Review+2 I think the proper approach is to have MAXLEN to be 32 and only use MAXLEN+1 when sizing the array. But well, up to you. -- To view, visit https://gerrit.osmocom.org/10754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d6cc96be252bb486e94f343a8c7cae641ff9429 Gerrit-Change-Number: 10754 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Tue, 04 Sep 2018 17:43:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
