Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/10770 )
Change subject: apps/grgsm_trx: add baseband frequency shift feature ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/10770/2/apps/grgsm_trx File apps/grgsm_trx: https://gerrit.osmocom.org/#/c/10770/2/apps/grgsm_trx@50 PS2, Line 50: phy_freq_offset_hz The way parameters (especially their default values) are handled currently is a bit messy. I'll migrate it to optparse or argparse. -- To view, visit https://gerrit.osmocom.org/10770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e397e47402a87f4141ef31b25eff4c8c1267e2 Gerrit-Change-Number: 10770 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Piotr Krysik <ptrkry...@gmail.com> Gerrit-Comment-Date: Wed, 05 Sep 2018 10:50:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
